Issue #257 Nightly Build #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis
#257
Make it easy for anyone interested in this project to get the latest binaries (OpenAM war).
Solution
Attach the
nightlytag to the build artifact and upload it to theopenam-jp/openam/releasespage.Using GitHub-Actions cron triggers to rebuild the
masterbranch source code every day.Specifications Issues and Proposals
1. GitHub packages or source code
I think there are two options: "use the binaries in GitHub-Packages if they are available" and "build everything from source".
I selected "Build everything from source", because one of the important purposes of nightly build is to detect specification changes and situation changes of dependent libraries at an early stage, and easier to operate.
2. Dealing with
http:protocol Maven repository URLsUsing the latest Maven, a build error will occur because the following two issues are unresolved.
By replacing
http:where the problem occurs withhttps:, build errors can be avoided, so I implemented a simple ad-hoc patch.I think it is appropriate to proceed with the above two issues after proper consideration.
Ad-hoc patches should be removed in the future when the root cause is resolved.